Skip to content

Clean up WallPost JS outside of webpack

Chris Oelmueller requested to merge wallpost-module into master

What does this MR do?

  • move legacy WallPost JS from inline PHP to proper JS, handle with webpack
  • explicit imports in all modules using it (rename to solve camelcase linter warnings)
  • scope the associated CSS under the wallpost module, very minor cleanup
  • fix a bug with deleting wallpost on own profile forOnly in beta

How confident are you it won't break things if deployed?

well.............. let's say I would be more surprised if nothing breaks than I would if something does. I'm scheduling this MR for early in the next testing cycle, so we can have more time for discovering problems.

Links to related issues

How to test

Before checking out this MR, write some wallposts with different users in the various supported context cases (see the MR changes for a list of them; every initWall).

Then, test that all those posts are still present afterwards as expected, that you can write new ones with/without attached images, delete old and new posts, and see all data and UI elements that were there before.

important to know: there is a bug with preview thumbnails in usernotes that was neither introduced nor fixed by my changes. the images themselves exist and will display!

Checklist

  • refactoring only, nothing new
  • no unrelated changes after !1770 (merged) is merged
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo
Edited by Chris Oelmueller

Merge request reports