Skip to content

Set webcal as protocol and second link for webcal with events.

Christian Walgenbach requested to merge webcal_url into master

Related to #80 (closed)

What does this MR do?

The hidden section https://foodsharing.de/?page=settings&sub=calendar was addressed in the product working group.

Question: Whether chats, wall boards or store descriptions would be read less. Unanimous agreement that this has rather a better reliability than disadvantages. Jörg suggested:

  1. to change the URL from http/s:// to webcal://, so that this is directly recognized by end devices as a calendar.
  2. Possibility with the parameter "&opts=se" to include events in addition to the pick-ups. I have included these with an additional link.

How confident are you it won't break things if deployed?

(be honest!)

Links to related issues

https://beta.foodsharing.de/?page=bezirk&bid=2296&sub=forum&tid=115911 (product workgroup)

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. ...

Screenshots (if applicable)

Bildschirmfoto_von_2020-10-16_14-36-36

Bildschirmfoto_von_2020-10-16_14-37-22

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Christian Walgenbach

Merge request reports