Skip to content

Fix #984 to correct broken text-overflow handling in Firefox

Chris Oelmueller requested to merge 984-fix-trafficlight-firefox into master

the text-truncate class on the main (inline!) element was problematic for several reasons.

now use flexbox now to handle the layouting and set predefined margins (on both sides!) instead of messing with absolute positioning.

Closes #984 (closed)

How confident are you it won't break things if deployed?

Didn't test Internet Explorer but aside from that, it will help more than hurt.

How to test

  • have some stores with long names (such that they are clipped) and a traffic light status
  • look at them in Firefox and other browsers, with and without the commit in this branch

Screenshots (if applicable)

before:
image

after:
image

There are no tests, changelog or release notes items needed for this adjustment.

Merge request reports