Skip to content

Minor dashboard view refactoring

Chris Oelmueller requested to merge refactor/dashboard-view into master

What does this MR do?

  • annotate some XhrMethods
  • general quality-of-life refactoring in XhrMethods (check by commit there) and FoodsaverXhr
  • refactor a weird-looking permission check in DashboardControl
  • combine two similar methods (foodsharer dashboard baskets) into one

How confident are you it won't break things if deployed?

should be okay, I'm around if it's not :)

Links to related issues

How to test

Good question. Carefully reviewing the commit changes would be helpful. That plus maybe

  • playing around with dates, since TimeHelper was slightly modified
  • check foodsharer dashboards in the two variants (you might need geolocation for the nearby-case)
  • test signing out of store teams

Most of this will be tested organically on Beta too.

Checklist

  • no test: no functional change
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • forDev => no release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Chris Oelmueller

Merge request reports