Lint some PHP
What does this MR do?
Plain and mostly simple refactoring triggered by some PHPstan output:
- lots of type hints
- remove unused (and barely used) stuff
- some flattening
- some whitespace adjustments
How confident are you it won't break things if deployed?
Fairly
Links to related issues
Checklist
-
no test needed: functionality should remain identical -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md Some PHP linting chores and more type hints !1641 @ChrisOelmueller
-
no release notes relevance (forDev)
Edited by Chris Oelmueller