Skip to content

Fix buddy bells

Alex requested to merge 942-fix-buddy-bell into master

Closes #942 (closed)

What does this MR do?

Fixes the proper creation and deletion of buddy bells. In the creation the non-null field 'closable' was set to null. The deletion didn't work because of a typo in the bell identifier.

How confident are you it won't break things if deployed?

Very sure

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to the profile of another user
  4. Send a buddy request ("Ich kenne...")
  5. Login as that user
  6. See if there's a bell in the topbar

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes: I don't think it needs to be included in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports