Skip to content

Banana REST endpoint

Alex requested to merge banana-rest into master

Part of #798 (closed) and #489

What does this MR do?

Moves the sending of bananas to a new REST endpoint. Also, fixes that it was possible to give yourself a banana (#489). The front-end behavior for users should not change at all.

How confident are you it won't break things if deployed?

Very sure

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to the profile page of another user
  4. Try to give a banana with a short message (< 100 letters) -> you should see an error message
  5. Giving a banana with a longer message should work

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports