Skip to content

filter outdated baskets from REST responses

Alex requested to merge 706-filter-outdated-baskets into master

Closes #706 (closed)

What does this MR do?

Outdated baskets are still included in the responses from REST endpoints until they are deleted by the nightly maintenance. This filters them from the responses because for users outdated baskets are not accessible anymore.

How confident are you it won't break things if deployed?

Quite sure. Can there be special cases which I didn't of?

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Have an active basket in your list in the topbar - create a new one if there is none
  4. Set the basket's 'until' value to some time in the past (via the database)
  5. The basket should not appear in the topbar anymore (or in http://localhost:18080/api/baskets)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports