Skip to content

Modernize generated bell data

Chris Oelmueller requested to merge bugfix/907-modernize-bell-data into master

Closes #907 (closed) (the code part of it anyways)

What does this MR do?

Insert native fontawesome icons into newly generated bell notifications, getting rid of the hack that was in place to override the old class names from way before.

How confident are you it won't break things if deployed?

I'm not unconfident. The removed CSS is unused only for the future, so some of the old icons will not show up anymore (particularly noticeable after this is released to production).
As this is only a UI issue, and people are casually deleting many of their bells anyways, I don't consider a missing icon here or there a big enough deal to warrant database manipulation.

It could be described in the release notes though, so that

  • some folks will read it and understand there's no bug
  • we can point the others that notice missing icons to the release notes for an explanation

I am willing to prepare the German release notes section for this MR at some appropriate time.

Links to related issues

basically the description of #907 (closed)

How to test

BEFORE TESTING THE BRANCH:

  • generate some bells in the places that were adjusted here (store or fairteiler bells)

Then, switch to the branch and

  • check the old bells (their icons should no longer show up)
  • generate new bells in those places (these icons should be displayed)
  • if you like, also look around dashboard updates, though I'm 100% certain that CSS was unused

Screenshots (if applicable)

no visual change in the future.
old "missing" bells will look like this:
image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports