Skip to content

Fix #912 - allow opening bell notifications in new tab

Chris Oelmueller requested to merge feature/912-bell-click-handling into master

Closes #912 (closed)

What does this MR do?

When clicking on bell notifications right now, we use a click handler (to mark bells as read and manually set window.location to the bell href). This works, but prevents

  • seeing the URL where you'll end up before clicking on it
  • "opening the bell" in a new tab by using middle-click

This MR introduces a better workflow for users receiving many bells, by allowing them to open bells in new tabs with middle mouse clicks. All that while still marking the bell as read, and while not losing the previous left-click functionality.

How confident are you it won't break things if deployed?

Unless there are bells with an invalid href somewhere, this shouldn't break anything that was working before.

How to test

  • generate some bells
  • click on them (left, middle clicks)
  • check that bell visibility and page targets are as expected
  • also check if this is possible on mobile with e.g. long/force taps

Checklist

  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Christian Walgenbach

Merge request reports