Skip to content

Use existing endpoint for baskets in topbar

Alex requested to merge basket-list-use-endpoint into master

What does this MR do?

Replaces the XHR request for the basket list in the topbar and uses the existing REST endpoints. This removes a ToDo entry and an old xhr function from the code. The front-end behavior should still be the same.

How confident are you it won't break things if deployed?

Quite sure, but some more testing would be great

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Create a food basket
  4. Login as another user
  5. Go to that food basket and send a request
  6. Login as the first foodsaver again
  7. Check if you can see the basket and the request with correct dates in the topbar

Checklist

  • added a test, or explain why one is not needed/possible... covered by existing tests
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports