Switch map server to Geoapify and integrate mapbox gl to render their vector tiles
What does this MR do?
We will use Geoapify as the new map server. Since, leaflet can not render vector tiles I needed to additionally integrate the mapbox gl library.
To make it work locally, I needed to make some changes with the content security policy.
How confident are you it won't break things if deployed?
I had some issues with setting up the content security policy. Would be good if someone can take a look at it with more experience with this stuff :)
Links to related issues
Related Slack Thread: https://yunity.slack.com/archives/CRL49VCJ1/p1581190646053100
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Test whether the map is displayed properly at the following places
- The global map under /karte http://localhost:18080/karte
- The address pick map under settings http://localhost:18080/?page=settings&sub=general
- The map on a basket detail page http://localhost:18080/essenskoerbe/38971
- The find basket map (click on the basket in the topbar and then on "all baskets") http://localhost:18080/essenskoerbe/find
- The region admin tool http://localhost:18080/?page=region (log in as orga)
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Merge request reports
Activity
added 2 commits
- Resolved by Johannes
Works fine locally! For me it even feels like looking sharper. Maybe I'm only thinking this kowing this is vector based ;) Thanks for pushing this forward!!
I added links and a missing spot with a maps to your MR text
- Resolved by Johannes
added 7 commits
-
6dfc419b...83d2c4f2 - 4 commits from branch
master
- 42043784 - fix map initialization test
- ef5ef3be - update chagelog
- 00a6cb85 - switch mapserver to geoapify and integrate mapbox gl
Toggle commit list-
6dfc419b...83d2c4f2 - 4 commits from branch
added 19 commits
-
4cc17ab0...5461a3b4 - 15 commits from branch
master
- 7f7f0294 - fix map initialization test
- 207459dd - update chagelog
- 4bb26ff9 - switch mapserver to geoapify and integrate mapbox gl
- a1b3b6c4 - fixes acceptance test
Toggle commit list-
4cc17ab0...5461a3b4 - 15 commits from branch
- Resolved by Johannes
Fast-forward merge is not possible. To merge this request, first rebase locally.
added 6 commits
-
a1b3b6c4...88ef136f - 2 commits from branch
master
- 7016c745 - fix map initialization test
- ca250500 - update chagelog
- 684dbe43 - switch mapserver to geoapify and integrate mapbox gl
- d48faec9 - fixes acceptance test
Toggle commit list-
a1b3b6c4...88ef136f - 2 commits from branch
enabled an automatic merge when the pipeline for d48faec9 succeeds