Skip to content

Resolve "Hidden broadcast overlay message"

Christian Walgenbach requested to merge 447-fix-height-topbar into master

Closes #447 (closed)

What does this MR do?

Set height for topbar and reduces the height of div # main

How confident are you it won't break things if deployed?

I am very sure because I have tested different resolutions and browsers.

Links to related issues

https://yunity.slack.com/archives/C1T1ZM9A4/p1584187611271500

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as orgauser
  3. Put content into broadcast_info (content 51). This enables that text being shown on every page.
    http://localhost:18080/?page=content&a=edit&id=51
  4. Test in different browser and devices

Screenshots (if applicable)

Bildschirmfoto_von_2020-03-14_14-40-07

Bildschirmfoto_von_2020-03-14_14-39-52

Bildschirmfoto_von_2020-03-14_14-38-40

Bildschirmfoto_von_2020-03-14_14-39-17

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Christian Walgenbach

Merge request reports