Fix sentry bug for food share points
What does this MR do?
Fixes two bugs that happen for food share points if a region id is not set properly:
- https://sentry.io/share/issue/1dfce45359dc4e858409e3695313b262/
- https://sentry.io/share/issue/eea3eb6a2d0540d4ad729345608c948c/
It's probably caused by a wrong 'bid' field in the query. I have no idea why that could be wrong, but the $regionId
variable is only set in one place which had a missing if case, so I think this should fix it.
How confident are you it won't break things if deployed?
Quite sure, I don't see a way how this could break anything.
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Go to the page of a food share point
and
- Login as bot
- Go to the edit page of a food share point
... where everything should still look and behave the same.
Screenshots (if applicable)
Any relevant screenshots if this is a design / frontend change
Checklist
-
added a test, or explain why one is not needed/possible... might still be covered by existing tests (?) -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Merge request reports
Activity
added 28 commits
-
63d8deb3...75188575 - 27 commits from branch
master
- 292297a2 - fix missing region id bug for food share points
-
63d8deb3...75188575 - 27 commits from branch
added typeBug + 1 deleted label
assigned to @alex.simm
added 11 commits
-
292297a2...dfc9f5c8 - 8 commits from branch
master
- 17e2e8fd - replace deprecated formatDuration method.
- e89d78b4 - fix missing region id bug for food share points
- 7f692619 - rebase fix
Toggle commit list-
292297a2...dfc9f5c8 - 8 commits from branch
added 96 commits
-
7f692619...76314582 - 93 commits from branch
master
- 0ff3306c - replace deprecated formatDuration method.
- 94673ea0 - fix missing region id bug for food share points
- 31231606 - rebase fix
Toggle commit list-
7f692619...76314582 - 93 commits from branch
added 25 commits
-
31231606...48801e59 - 22 commits from branch
master
- 289b37b2 - replace deprecated formatDuration method.
- de6cea6e - fix missing region id bug for food share points
- 2dee5a58 - rebase fix
Toggle commit list-
31231606...48801e59 - 22 commits from branch
enabled an automatic merge when the pipeline for 2dee5a58 succeeds
added stateBeta testing label
changed milestone to %Release 'Apfelsine': May 2020
mentioned in merge request !1509 (merged)
removed stateBeta testing label