Skip to content
Snippets Groups Projects

Fix sentry bug for food share points

Merged Alex requested to merge fsp-region-bug-fix into master

What does this MR do?

Fixes two bugs that happen for food share points if a region id is not set properly:

It's probably caused by a wrong 'bid' field in the query. I have no idea why that could be wrong, but the $regionId variable is only set in one place which had a missing if case, so I think this should fix it.

How confident are you it won't break things if deployed?

Quite sure, I don't see a way how this could break anything.

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to the page of a food share point

and

  1. Login as bot
  2. Go to the edit page of a food share point

... where everything should still look and behave the same.

Screenshots (if applicable)

Any relevant screenshots if this is a design / frontend change

Checklist

  • added a test, or explain why one is not needed/possible... might still be covered by existing tests (?)
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Alex

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading