Skip to content

Remove deprecated permission functions

Koen van Greevenbroek requested to merge koen-remove-deprecated-permission-functions into master

What does this MR do?

Removes the two deprecated functions mayHandleReports and mayEditQuiz from Session.php. Replaces calls to these functions by calls to the respective functions in the ReportPermissions and QuizPermissions classes.

How confident are you it won't break things if deployed?

Quite confident.

How to test

In the pipeline testing we trust. There is no change in behaviour, just a refactoring.

Checklist

  • no extra test necessary for a simple refactoring
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Koen van Greevenbroek

Merge request reports