Removed unused clearAbholer() method, which would falsely remove all fetches...
All threads resolved!
All threads resolved!
What does this MR do?
Removed unused clearAbholer()
method, which would falsely remove all fetches from a user which need to stay for documentary reason
How confident are you it won't break things if deployed?
Very
Links to related issues
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Johannes
Merge request reports
Activity
added typeRefactoring + 1 deleted label
- Resolved by David
Afaik we need to only store the fetches for five years, don't we? So in general such method could be exist :)
added 22 commits
-
500d3331...7ac6d81f - 20 commits from branch
master
- f34c5369 - Removed unused clearAbholer() method, which would falsely remove all fetches...
- 56640777 - Added changelog with merge request number
-
500d3331...7ac6d81f - 20 commits from branch
enabled an automatic merge when the pipeline for 56640777 succeeds
changed milestone to %January 2020 release
Please register or sign in to reply