Skip to content
Snippets Groups Projects

Fixes dashboard sorting

Merged Christian Wansart requested to merge 681-fix-dashboard-sorting into master

Closes #681 (closed)

What does this MR do?

The dashboard sorting failes when there are events (Termine) in it since they don't have a time attribute. This leads to an exception and thus prevents the further execution of the sort function. The current state is as follows: the events get listed on top. In the dashboard activity they are not shown. This behavior does not change by this fix but it will fix the sorting of the page.

How confident are you it won't break things if deployed?

See the screenshots: without-fix with-fix

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Chris Oelmueller

Merge request reports

Pipeline #77856435 passed

Pipeline passed for b4806080 on 681-fix-dashboard-sorting

Approved by

Merged by Peter TönniesPeter Tönnies 5 years ago (Aug 23, 2019 5:37am UTC)

Merge details

  • Changes merged into master with b4806080 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading