Skip to content

Do not expose outdated baskets via the rest api

David requested to merge rest-outdated-baskets into master

Closes foodsharing-android#72 (closed)

What does this MR do?

Checks in the get basket rest action whether the basket is already expired and returns a 404 for expired baskets.

How confident are you it won't break things if deployed?

Afaik, this is currently only used in the Android app and would show the same behaviour as if the basket would have been deleted.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))

Merge request reports