Skip to content

Fix javascript error on null "string"

Matthias Larisch requested to merge fix_js_photo_null_error into master

What does this MR do?

Implements a null-check in client js before the string length is checked (photo field used to display avatars). This became necessary by a recent database change. For new users without a photo, this would lead to JS errors.

At best, see the issue when opening the conversations list as userbot@example.com in our dev seed data and switching between the two conversations. This MR fixes it. I was too lazy to implement an acceptance test :(

How confident are you it won't break things if deployed?

quite sure.

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
Edited by Nick Sellen

Merge request reports