Messages to work groups (AGs) shouldn't just be from noreply@foodsharing.de
Summary
Currently, messages to work groups sent via https://foodsharing.de/?page=groups use noreply@foodsharing.de as sender (see !749 (merged)) and the user's private email address as reply-to.
Steps to reproduce
Use the form on https://beta.foodsharing.de/?page=groups to send a message to a work group. Use beta for now to obtain a copy to your own proper mailbox since #493 (closed) is not fixed in prod yet.
What is the current bug behavior?
FROM: noreply@foodsharing.de REPLY-TO: your email
What is the expected correct behavior?
-
At the very least FROM: "Username noreply@foodsharing.de" -
It would be even better to use the proper mail address directly instead of as reply-to if that is compatible with the reasoning behind !749 (merged)).
Relevant error messages and/or screenshots
Possible fixes
- https://gitlab.com/foodsharing-dev/foodsharing/blob/e531da79ad04793927584cd527c3ab46f07dc308/src/Helpers/EmailHelper.php#L57
- https://gitlab.com/foodsharing-dev/foodsharing/blob/c306cc4946bb6702debb9a3b075d5f82f1615e15/src/Modules/WorkGroup/WorkGroupXhr.php#L115
- Also see https://yunity.slack.com/archives/C1T1ZM9A4/p1552908765246200