1. 26 Mar, 2020 2 commits
  2. 25 Mar, 2020 1 commit
  3. 23 Mar, 2020 1 commit
  4. 06 Mar, 2020 3 commits
  5. 28 Feb, 2020 5 commits
  6. 26 Feb, 2020 1 commit
  7. 25 Feb, 2020 1 commit
  8. 24 Feb, 2020 2 commits
  9. 16 Feb, 2020 1 commit
  10. 29 Jan, 2020 1 commit
    • Fabiano Fidêncio's avatar
      loader: Avoid conflicting object ids for extension files · aa43e762
      Fabiano Fidêncio authored
      Currently, when building the id of some of our objects, we do:
      - Loop over the several objects of that type;
        - Concatenate the id of the parent object with the loop index;
      
      By doing this, conflicts can be seen when using more than one extension
      file, as osinfo-db does for Windows, where pre and post installable
      drivers extension files are used and end up being loaded as we'd do:
      
      - Loop over pre installable drivers;
        - Concatenate the id of the parent object with the loop index;
      
      - Loop over post installable drivers;
        - Concatenate the id of the parent object with the loop index;
      
      In order to avoid such issues, let's also use the filename as part of
      the object id, avoiding then conflicts.
      
      It's important to note that the conflict is cause by osinfo_list_add(),
      which will replace the object in the list in case some other object with
      the very same id is already stored there.
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      aa43e762
  11. 25 Jan, 2020 1 commit
  12. 24 Jan, 2020 1 commit
  13. 13 Jan, 2020 2 commits
  14. 10 Jan, 2020 5 commits
  15. 09 Jan, 2020 1 commit
  16. 07 Jan, 2020 2 commits
  17. 03 Jan, 2020 10 commits
    • Fabiano Fidêncio's avatar
      loader: Introduce OsinfoError enum · 1c80d841
      Fabiano Fidêncio authored
      Let's create an OsinfoError enum instead of just using 0 as the error
      type. This solves the following instrospection warning:
      ```
      <unknown>:: Warning: Libosinfo: (ErrorQuarkFunction)error_quark: osinfo_error_quark: Couldn't find corresponding enumeration
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      1c80d841
    • Fabiano Fidêncio's avatar
      product: Use product instead of prod as argument name · 7a1e523a
      Fabiano Fidêncio authored
      Header, source, and documentation were not matching with regarding to
      the argument product name.
      
      Let's standardise them and use product all over the place. By doing this
      the following warnings will be fixed:
      ```
      ../osinfo/osinfo_product.c:318: Warning: Libosinfo: osinfo_product_get_codename: unknown parameter 'product' in documentation comment, should be 'prod'
      ../osinfo/osinfo_product.c:329: Warning: Libosinfo: osinfo_product_get_release_date_string: unknown parameter 'product' in documentation comment, should be 'prod'
      ../osinfo/osinfo_product.c:342: Warning: Libosinfo: osinfo_product_get_eol_date_string: unknown parameter 'product' in documentation comment, should be 'prod'
      ../osinfo/osinfo_product.c:369: Warning: Libosinfo: osinfo_product_get_release_date: unknown parameter 'product' in documentation comment, should be 'prod'
      ../osinfo/osinfo_product.c:388: Warning: Libosinfo: osinfo_product_get_eol_date: unknown parameter 'product' in documentation comment, should be 'prod'
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      7a1e523a
    • Fabiano Fidêncio's avatar
      install_config: Don't use different variable names in .c and .h · 4b88b5ca
      Fabiano Fidêncio authored
      The tz variable, used in the source file, is declared in the header file
      as timezone. Let's just use the same name used in the header as it's
      more descriptive.
      
      By doing so, the following GTK-Doc warning is fixed:
      ```
      ../osinfo/osinfo_install_config.c:231: Warning: Libosinfo: osinfo_install_config_set_l10n_timezone: unknown parameter 'tz' in documentation comment, should be 'timezone'
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      4b88b5ca
    • Fabiano Fidêncio's avatar
      os: Move the "Since: " annotation · be1ed75e
      Fabiano Fidêncio authored
      The "Since: " annotation should be *always* added to the end of the
      comment block. More than that, multiplce "Since: " annotations cannot be
      part of a same comment block and in order to solve that, let's avoid
      adding a "Since: " in the end of the block, but explicitly mention when
      each of the values were added.
      
      By taking this approach, the following warnings can be avoided:
      ```
      ../osinfo/osinfo_os.h:90: Warning: Libosinfo: "@OSINFO_RELEASE_STATUS_RELEASED" parameter unexpected at this location:
       * @OSINFO_RELEASE_STATUS_RELEASED: A released OS.
          ^
      ../osinfo/osinfo_os.h:96: Error: Libosinfo: multiple "Since:" tags for identifier "OsinfoReleaseStatus":
       * Since: 1.4.0
         ^
      ../osinfo/osinfo_os.h:97: Warning: Libosinfo: "@OSINFO_RELEASE_STATUS_ROLLING" parameter unexpected at this location:
       * @OSINFO_RELEASE_STATUS_ROLLING: A rolling version of an OS and thus with no
          ^
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      be1ed75e
    • Fabiano Fidêncio's avatar
      tree: Move the "Since: " annotation · a1547279
      Fabiano Fidêncio authored
      Let's move the "Since: " annotation to the end of the comment block,
      otherwise the following warning will be shown:
      ```
      ../osinfo/osinfo_tree.h:41: Warning: Libosinfo: "@OSINFO_TREE_ERROR_NO_TREEINFO" parameter unexpected at this location:
       * @OSINFO_TREE_ERROR_NO_TREEINFO: No treeinfo found;
          ^
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      a1547279
    • Fabiano Fidêncio's avatar
      install_script: Move the "Since: " annotation · b106bd22
      Fabiano Fidêncio authored
      Let's move the "Since: " annotation to the end of the comment blocks,
      otherwise the following warnings will be shown:
      ```
      ../osinfo/osinfo_install_script.h:100: Warning: Libosinfo: "@OSINFO_DEVICE_DRIVER_SIGNING_REQ_NONE" parameter unexpected at this location:
       * @OSINFO_DEVICE_DRIVER_SIGNING_REQ_NONE: Script do not require device drivers
          ^
      ../osinfo/osinfo_install_script.h:123: Warning: Libosinfo: "@OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_CDROM" parameter unexpected at this location:
       * @OSINFO_INSTALL_SCRIPT_INJECTION_METHOD_CDROM: Support injection of the
          ^
      ../osinfo/osinfo_install_script.h:145: Warning: Libosinfo: "@OSINFO_INSTALL_SCRIPT_INSTALLATION_SOURCE_MEDIA" parameter unexpected at this location:
       * @OSINFO_INSTALL_SCRIPT_INSTALLATION_SOURCE_MEDIA: A media will be used as
          ^
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      b106bd22
    • Fabiano Fidêncio's avatar
      install_config_param: Fix annotation for _get_value_map() · c49de291
      Fabiano Fidêncio authored
      The function name was wrong, causing the following warning:
      ```
      ../osinfo/osinfo_install_config_param.h:94: Warning: Libosinfo: osinfo_install_config_param_get_value_map: return value: Missing (transfer) annotation
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      c49de291
    • Fabiano Fidêncio's avatar
      install_config_param: Don't use invalid "transfer" annotation · 22a43efc
      Fabiano Fidêncio authored
      "transfer" annotation shouldn't be used with gboolean or enums, causing
      the following warnings:
      ```
      ../osinfo/osinfo_install_config_param.c:252: Warning: Libosinfo: invalid "transfer" annotation for gboolean: only valid for array, struct, union, boxed, object and interface types
      ../osinfo/osinfo_install_config_param.c:267: Warning: Libosinfo: invalid "transfer" annotation for gboolean: only valid for array, struct, union, boxed, object and interface types
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      22a43efc
    • Fabiano Fidêncio's avatar
      install_config_param: Move the "Since: " annotation · 3dba1d28
      Fabiano Fidêncio authored
      Let's move the "Since: " annotation to the end of the comment block,
      otherwise the following warning will be shown:
      ```
      ../osinfo/osinfo_install_config_param.h:50: Warning: Libosinfo: "@OSINFO_INSTALL_CONFIG_PARAM_POLICY_NONE" parameter unexpected at this location:
       * @OSINFO_INSTALL_CONFIG_PARAM_POLICY_NONE: no policy defined
          ^
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      3dba1d28
    • Fabiano Fidêncio's avatar
      loader: Remove ueseless /** PUBLIC METHODS */ comment · a557c298
      Fabiano Fidêncio authored
      The comment is not exactly helpful and causes the following GTK-Doc
      error:
      ```
      ../osinfo/osinfo_loader.c:133: Error: Libosinfo: Skipping invalid GTK-Doc comment block:
      /** PUBLIC METHODS */
      ^
      ```
      Signed-off-by: Fabiano Fidêncio's avatarFabiano Fidêncio <[email protected]>
      a557c298