OOE Regen Duration for SCH under Addendum: White or Tabula Rasa
The following box must be ticked:
-
I have searched the issue tracker and verified that the issue had not already been reported -
I'm aware that the developers who will handle this issue are not GMs and cannot assist with my player-specific issues. To my best knowledge, this issue is a bug which affects everyone.
Detailed description:
It appears that in issue #1535 (closed), the changes we made to remove the OOE Regen potency boost and duration were limited solely to the effect of light arts. If you use the stratagem Addendum: White while in light arts, light arts is actually replaced by the buff Addendum: White - where these OOE modifications to regen were not removed. Evidence and helpful info as follows:
- Addendum: White buffing regen in abilities/addendum_white.lua line 36
- Tabula Rasa at abilities/tabula_rasa.lua buffing regen on line 19
- ALSO appears to be giving an OOE buff to helix spells on line 24, though I have not tested this bonus specifically. Whether or not to include this in the scope of this issue is up to y'all.
- The commit where we removed these exact same regen buffs from only light arts in #1535 (closed): 9fbe16ec
I can also provide sources proving that these boosts to regen (and likely also helices in the case of Tabula Rasa) are OOE on request, though I'd hope that won't be necessary given the information on #1535 (closed)
As much as it pains me to slap SCH with a nerf, I figured I should at least bring these likely unintended boosts to regen (and likely the helix spells) to light.
Exact steps to reproduce:
- Switch to SCH level 20 or higher (the higher the better)
- Activate Light Arts
- Use the stratagem Addendum: White
- Cast the spell Regen or Regen II on yourself or a party member
Expected behavior:
- The duration of Regen and Regen II remains a static 75 seconds and 60 seconds respectively
Observed behavior:
- The duration of Regen and Regen II are boosted by 30 seconds under Addendum: White, 30 seconds under Tabula Rasa, and 1 minute under both as a level 69 (nice) Scholar.
- The 30 seconds comes from the effects files (at addendum_white.lua, tabula_rasa.lua, and light_arts.lua) where regen is derived from the equation
regenbonus = 3 * math.floor((player:getMainLvl() - 10) / 10)
on the corresponding abilities files (abilities/addendum_white.lua and abilities/tabula_rasa.lua). So3*floor((69-10)/10)
which equals 15, that is then multiplied by 2 in the effects files.
- The 30 seconds comes from the effects files (at addendum_white.lua, tabula_rasa.lua, and light_arts.lua) where regen is derived from the equation
- The potency of the regen appears to be unchanged, remaining at 5/tic for Regen and 12/tic for Regen II
- This means that Regen heals for 50 more hp, and Regen 2 heals for 120 more hp under the effects of just Addendum: White or Tabula Rasa. 100 more hp and 240 more hp respectively if under the effects of both...
Client version (type /ver in game):
- 30190305_0