Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
Jekyll Plugin
Jekyll Plugin
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 13
    • Issues 13
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge Requests 3
    • Merge Requests 3
  • Requirements
    • Requirements
    • List
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • External Wiki
    • External Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • F-Droid
  • Jekyll PluginJekyll Plugin
  • Issues
  • #38

Closed
Open
Opened Jun 20, 2017 by Peter Serwylo@pserwyloReporter

/packages URLs are incorrectly prefixed with "/en/en"

I've just noticed this after firing up a linkchecker over the website. You can see it here, where it fails to load any CSS assets, and all of the links are broken.

After investigating, the reason is because the polyglot plugin prefixes URLs in each page like so:

  • Iterate over each Jekyll collection and their pages and fix up their URLs
  • Iterate over

See here:

# hook to make a call to process rendered documents,
Jekyll::Hooks.register :site, :post_render do |site|
  site.collections.each do |_, collection|
    site.process_documents(collection.docs)
  end
  site.process_documents(site.pages)
end

This is all well and good, except that when we run jekyll-fdroid, it solves its problem by appending each of its generated package .html files to the sites pages. In addition, it is seen as a "collection" also, so it ends up correcting the URL twice, once for site.process_documents(collection.docs) and once for site.process_documents(site.pages).

This could equally be logged in jekyll-fdroid, but I'm not fussed. I'll continue investigating to get a better picture of what is going on and how to solve it. Perhaps a patch upstream is neccesary, maybe we can just tweak jekyll-plugin and the way it generates pages.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: fdroid/jekyll-fdroid#38