Skip to content

UTF-8 fixes

Hans-Christoph Steiner requested to merge eighthave/fdroidserver:utf8-fixes into master

Fastlane/Triple-T app store metadata files must be in UTF-8. Before this would crash if they were not. This changes the handling to just replace the non-UTF8 chars with a �. Here's the stacktrace from build/net.sourceforge.x11basic/fastlane/metadata/android/de-DE/full_description.txt:

    CRITICAL: Unknown exception found!
    Traceback (most recent call last):
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroid", line 164, in <module>
        main()
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroid", line 159, in main
        raise e
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroid", line 138, in main
        mod.main()
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroidserver/update.py", line 2010, in main
        insert_localized_app_metadata(apps)
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroidserver/update.py", line 885, in insert_localized_app_metadata
        os.path.join(root, f))
      File "/var/lib/jenkins/userContent/reproducible/reproducible_fdroid_build_apps/fdroidserver/update.py", line 700, in _set_localized_text_entry
        text = fp.read()[:limit]
      File "/usr/lib/python3.5/codecs.py", line 321, in decode
        (result, consumed) = self._buffer_decode(data, self.errors, final)
    UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfc in position 94: invalid start byte

Merge request reports