Lint should check gradle *after* `patch` was applied
Currently, lint checks the gradle of a build before the corresponding patch:
(if it exists) is executed. This leads to "false alerts" in cases where patch
fixes gradle issues – e.g. as reported in fdroiddata#1266 (closed):
Build:1.08 Beta 4,58
commit=1_08_b4
subdir=MPDroid
patch=0001-remove-fabric.io-and-crashlytics.patch,0002-remove-versionName-logic.patch
gradle=foss
This is a snipped of the MPDroid (com.namelessdev.mpdroid
) metadata. But despite of the patch removing Crashlytics from the corresponding gradle, lint fails with:
build/com.namelessdev.mpdroid/MPDroid/build.gradle
repositories {
mavenCentral()
maven { url 'http://download.crashlytics.com/maven' }
gradle build uses plain HTTP URLs for repositories! This is insecure!
Would it run after the patch being applied, the pipeline had succeeded.
TL;DR: could we have configured patches applied before lint checks the gradle?