Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • fdroidserver fdroidserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 296
    • Issues 296
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 45
    • Merge requests 45
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • F-Droid
  • fdroidserverfdroidserver
  • Merge requests
  • !721

yamllint

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michael Pöhn requested to merge uniqx/fdroidserver:yamllint into master Feb 29, 2020
  • Overview 15
  • Commits 9
  • Pipelines 12
  • Changes 7

This adds yamllint checks for helping users understand issues with their metadata files. (as suggested in #745 (closed))

  • yamllint is added as an optional dependency. So if it's not installed checks will be skipped (silently)
  • checks are only taking place in 4 cases:
    • when pyyaml fails to parse any .yml srclibs or app-metadata file
    • when fdroid lint is gets called app-metadata files and all their references srclib files
      (running yamllint for all .yml srclib and app-metadata files increases execution-time by an order of magnitude. On my test environment from 8.77s to 104.99s. So when running fdroid lint without a specific list of appids yamllint is off by default. I've added an option to run it regardless: --force-yamllint)

Here's an example of how yamllint output will look like:

$ fdroid lint --force-yamllint
metadata/io.anuke.mindustry.yml:187: trailing spaces (trailing-spaces)
metadata/io.anuke.mindustry.yml:189: trailing spaces (trailing-spaces)
metadata/net.olejon.mdapp.yml:155: trailing spaces (trailing-spaces)
Edited Apr 25, 2020 by Michael Pöhn
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: yamllint