Skip to content

featureGraphic_sha, icon_sha files removed and not recreated

https://gitlab.com/fdroid/fdroidserver/-/blob/master/fdroidserver/update.py#L1035

If i store the repo content (output of fdroid update) in git (to generate pages from it by the hosting server), then os.path.samefile will be false, causing the os.unlink(f) to be used (due to how git handles links and how python checks i-nodes for the same file. Unfortunately, the conditional logic does not count with this possibility and the icon_sha... files will not be re-created in the same run, so it is possible that every other fdroid update the icon_sha files will be missing. If in fact the repository data are stored in another git repo and only the repo folder is synced to the server, the icon_sha files will never be present on the web host server.

edit: typo

Edited by Vanous
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information