If CVC is not explicitly set, per-release changelogs are not used
If CVC is not set explicitly via <packageName>.yml
, apply_info_from_latest_apk
sets it to that of the latest available *.apk
. Unfortunately, this happens after insert_localized_app_metadata
was run – so per-release changelogs are not picked up.
I've tested moving the call to insert_localized_app_metadata
(line 2131 in update.py
) behind the call to apply_info_from_latest_apk
(line 2143). This works fine for me on my "simple binary repo". From looking at the code, I'm 99.9% sure there are no side-effects – but not being the "pro Python developer" I'd prefer someone more familiar with it could have a second look.
I gladly make the corresponding MR if that is preferred for ease of check (as then the CI would already do some automated checking), so just tell me if I should.
copy_triple_t_store_metadata(apps)
insert_obbs(repodirs[0], apps, apks)
# Scan the archive repo for apks as well
if len(repodirs) > 1:
archapks, cc = process_apks(apkcache, repodirs[1], knownapks, options.use_date_from_apk)
if cc:
cachechanged = True
else:
archapks = []
# Apply information from latest apks to the application and update dates
apply_info_from_latest_apk(apps, apks + archapks)
insert_localized_app_metadata(apps)
translate_per_build_anti_features(apps, apks)
This is how it looks after my change. The last two lines formerly were right below insert_obbs
.