Long form NDK version - error when NDK already exists
...this might be limited to the CI and the contributor machines since main server has no preinstalled NDK, afaik
Steps:
- have an NDK in image eg.
/opt/android-sdk/ndk/23.2.8568313/
- recipe specifies
ndk: r23c
- builds fine - recipe specifies
ndk: 23.2.8568313
- fail
WARNING: Android NDK version '23.2.8568313' could not be found!
WARNING: Configured versions:
WARNING: r23c: /opt/android-sdk/ndk/23.2.8568313
INFO: Downloading https://dl.google.com/android/repository/android-ndk-r23c-linux.zip
DEBUG: Starting new HTTPS connection (1): dl.google.com:443
DEBUG: https://dl.google.com:443 "GET /android/repository/android-ndk-r23c-linux.zip HTTP/1.1" 200 724733960
INFO: Unzipping to /opt/android-sdk/ndk
ERROR: Could not build app com.github.meypod.al_azan due to unknown error: Traceback (most recent call last):
File "/home/vagrant/fdroidserver/fdroidserver/build.py", line 1116, in main
if trybuild(app, build, build_dir, output_dir, log_dir,
File "/home/vagrant/fdroidserver/fdroidserver/build.py", line 888, in trybuild
build_local(app, build, vcs, build_dir, output_dir, log_dir, srclib_dir, extlib_dir, tmp_dir, force, onserver, refresh)
File "/home/vagrant/fdroidserver/fdroidserver/build.py", line 374, in build_local
common.auto_install_ndk(build)
File "/home/vagrant/fdroidserver/fdroidserver/common.py", line 4220, in auto_install_ndk
_install_ndk(ndk)
File "/home/vagrant/fdroidserver/fdroidserver/common.py", line 4292, in _install_ndk
os.rename(extracted, ndk_dir)
OSError: [Errno 39] Directory not empty: '/opt/android-sdk/ndk/android-ndk-r23c' -> '/opt/android-sdk/ndk/23.2.8568313'
ref: #943 (closed)
ref: https://gitlab.com/fdroid/fdroiddata/-/jobs/3804160309#L1639
I guess it's an one-liner =
vs ==
vs :=
issue as usual with Python? Or another path issue?
Also we only have one app using this
Edited by Licaon_Kter