GitLab's annual major release is around the corner. Along with a lot of new and exciting features, there will be a few breaking changes. Learn more here.

Commit 56a53055 authored by Hans-Christoph Steiner's avatar Hans-Christoph Steiner
Browse files

build: bump max_apps_per_run to 50

With this at 10, it seems that there are often runs that produce no builds
at all.  That's bad.
parent 846a8c68
Pipeline #16063570 passed with stage
in 37 minutes and 38 seconds
......@@ -1177,7 +1177,7 @@ def main():
# Build applications...
failed_apps = {}
build_succeeded = []
max_apps_per_run = 10
max_apps_per_run = 50
for appid, app in apps.items():
max_apps_per_run -= 1
if max_apps_per_run < 1:
  • @eighthave Yop Hans, I checked a bit this code and thought this condition is weird because on 50 items only 49 will be treaten. Where will go apps[0]? I hope it's not in the failed_apps/good apps. If it's treaten after in the next loop (caller of build.py), ok.

    If you check all the exceptions of this for block, you will see that failed_app[ app.id ] should be 1st instruction executed. An another error can come in the several instructions just above, and probably the raise is not managed, blocking the next 'for' re-execution, the app never flagged as failed...

  • @hotlittlewhitedog: could you please start a new issue and maybe go into a bit more details with this bug report?

  • @hotlittlewhitedog its meant to be quick, temporary hack. Its already been removed.

Please register or sign in to reply
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment