Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Sign in / Register
Data
Data
  • Project
    • Project
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 111
    • Issues 111
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 108
    • Merge Requests 108
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • F-Droid
  • DataData
  • Merge Requests
  • !3623

Open
Opened Sep 02, 2018 by Nikhil Jha@nikhiljha 14 of 4 tasks completed4/4 tasks
  • Report abuse
Report abuse

Add App: Lobste.rs App

  • The app complies with the inclusion criteria
  • The original app author has been notified (and supports the inclusion)
  • All related fdroiddata and rfp issues have been referenced in this merge request
  • Builds with fdroid build

I tried to build it on MacOS, and I can't build anything in the repo because

  • it tries to use the deprecated android command
  • the vagrant setup uses import vagrant which apparently doesn't exist on PyPi (even though I have vagrant installed)
  • using fdroid build --server com.nikhiljha.lobstersapp errors with Couldn't open file /Users/nikhil/Dev/fdroiddata/builder/buildserver because it doesn't exist

This app is written using Flutter, so I shouldn't need the android command. Still it fails with...

ERROR: Could not build app com.nikhiljha.lobstersapp due to unknown error: Traceback (most recent call last):
  File "/usr/local/Cellar/fdroidserver/1.0.9/libexec/lib/python3.7/site-packages/fdroidserver/build.py", line 1120, in main
    options.onserver, options.refresh):
  File "/usr/local/Cellar/fdroidserver/1.0.9/libexec/lib/python3.7/site-packages/fdroidserver/build.py", line 896, in trybuild
    build_local(app, build, vcs, build_dir, output_dir, log_dir, srclib_dir, extlib_dir, tmp_dir, force, onserver, refresh)
  File "/usr/local/Cellar/fdroidserver/1.0.9/libexec/lib/python3.7/site-packages/fdroidserver/build.py", line 562, in build_local
    tarball.add(build_dir, tarname, exclude=tarexc)
TypeError: add() got an unexpected keyword argument 'exclude'

I think it should build (I basically copy-pasted another config), but I can't get it to build on my machine. Help would be appreciated.

Edited Sep 02, 2018 by Nikhil Jha

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch https://gitlab.com/nikhiljha/fdroiddata.git master
git checkout -b nikhiljha/fdroiddata-master FETCH_HEAD

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout origin/master
git merge --no-ff nikhiljha/fdroiddata-master

Step 4. Push the result of the merge to GitLab

git push origin master

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

  • Discussion 17
  • Commits 7
  • Pipelines 7
  • Changes 1
Assignee
No assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
0
Labels
None
Assign labels
  • View project labels
Reference: fdroid/fdroiddata!3623