UpstreamNonFree AF - clarify state
While NonFreeNet should be split (#553), UpstreamNotFree seems rather useless.
This was triggered by this commit d011d6e3 because I knew it had an AF (NonFreeDep as I've added a long time ago) so I was surprised it's not that one (I'll fix the description soon)
‘UpstreamNonFree’ - the application is or depends on Non-Free software. This does not mean that Non-Free Software is included with the app: Most likely, it has been patched in some way to remove the Non-Free code. However, functionality may be missing.
- is the source-code used by F-Droid free? Yes
- is the resulting APK free? Yes
- is the user freedom affected? No (functionality is freedom?)
- do we constantly use
sed
or patches to modify the source? Yes
From these I'm not sure if we have so many apps that are NOT UpstreamNonFree actually.
Now we have 108 marked with this AF, but not OSMAnd? Not Jitsi Meet? Not Element?
MaintainerNotes: We patch linphone-sdk to remove GMS and Firebase, thus UpstreamNonFree.
Umm, we patch most apps, a maintainer note about what's patched is nice, not sure a whole AF is needed for this.
I know about fdroidclient!1053 (merged) but that's not the point, it will help, but at the same time would force us to decide how deep can the patching go before using this AF. Also we'd need to parse all apps recipes and actually add this as needed, right? :-| But how much do we gain from this? The user?
/PS: This might be useful on non-F-Droid repos, since they can host whatever they want.