Guidelines for merging new apps
As recently discussed on IRC, we need more hands for getting RFPs done (well, same for other MRs, but that's a different issue). The recent rewrite of our IssueBot opens up new lanes for this, making it possible even for non-packagers/developers (like me) to know beforehand if an app would build with the "default build block".
First conclusion was, basically: if the bot shows no show-stoppers (such as "scanner errors" or the like), fastlane is there, no "red labels", all looks good – and the bot also added the "builds" label: instead of posting the full YAML metadata in a comment on that RFP, it can be directly used for an MR here. Which is what I'm doing for a few weeks now, with good success: most of those MRs have been merged already by our packagers.
Now @eighthave suggested that, if all pipelines on the MR succeed as well, and a resulting APK is uploaded with the assets, I could in principle push the "Merge" button myself as well.
I'm a bit hesitant doing that. I know our packagers do some more checks before that step – and they're right to insist on that. I certainly couldn't perform all of those steps with the same proficience. But what I'd like to know in this issue is:
- What steps are you performing (no need to write a book; a bullet-point list would be a good start)
- What steps would be considered the absolute minimum to justify "self-merging"?
Please kindly comment these below, @Bubu @licaon-kter @relan @Rudloff @uniqx @eighthave @mimi89999 (if I forgot one, apologies and feel invited nevertheless – even if you're not a contributor, expectations would be welcome, too)!
I'd then take the excerpt and add it to my snippets (a separate one maybe). A full story might be nice as blog post as well – who knows, it might invite additional helping hands.