Skip to content

App list layouts are broken

Hans, assigning to you since this all comes from the modifications made to res/layout/applistitem.xml in b0679252.

Below are the screenshots with layout bounds.

Old layout, normal: old_normal

Old layout, compact: old_compact

New layout, normal: new_normal

New layout, compact: new_compact

Issues:

  • Using the compact layout no longer makes more items fit in the list, since heights are now hard-coded (wtf?)
  • The icon is no longer centered properly. Why are we using hard-coded margins to center it artificially now? Seems wrong to me.
  • You also reverted some of my earlier changes. For example, the parent LinearLayout is no longer explicitly horizontal, which is a default but nevertheless lint asks for it to be explicit to avoid bugs.
  • dip is just an alias to dp. Before we used dp everywhere. Changing some sizes to dip and leaving others to dp for no reason is weird.

Granted that I could have seen some of these issues before merging the MR, but reading XML layouts is a pain and I just assumed that you did what needed to be done to simply transition to AppCompat. You seemingly rewrite most of the layout for no apparent reason, so I'm a bit confused. Stable release stopper for obvious reasons.

See 8ed76f47.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information