Commit d688831c authored by Hans-Christoph Steiner's avatar Hans-Christoph Steiner

gitlab-ci: make blank/unused translate output clearer

This test now shows the actual blank/unused translations, so it should
be a lot clearer why this test is failing.

!519
parent 0506fd4d
Pipeline #8420554 passed with stage
in 42 minutes and 56 seconds
......@@ -12,9 +12,11 @@ before_script:
test:
script:
- export EXITVALUE=0
- ./tools/check-format-strings.py
- ./tools/remove-unused-and-blank-translations.py
- git diff | grep diff && false # there should be no changes
- echo "These are unused or blank translations that should be removed:"
- git --no-pager diff --exit-code || export EXITVALUE=1
- ./gradlew assemble -PdisablePreDex
# always report on lint errors to the build log
- sed -i -e 's,textReport .*,textReport true,' app/build.gradle
......@@ -26,8 +28,9 @@ test:
echo "read $log here:";
cat "$log" | curl --silent -F 'clbin=<-' https://clbin.com;
done;
exit 1;
export EXITVALUE=1;
}
- exit $EXITVALUE
connected10:
variables:
......
  • Why didn't this go through a merge request? It's changing the behaviour and breaking it - leaving behind bad strings will no longer make CI fail.

  • Actually, I misread and I guess it's right, but the point remains.

  • I tested this both in cases where it should make the CI build succeed and where it should make it fail. It doesn't change the behavior, just adds more output to the log.

Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment