Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
  • Sign in / Register
  • Website Website
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 134
    • Issues 134
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 17
    • Merge requests 17
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Deployments
    • Deployments
    • Releases
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • F-Droid
  • WebsiteWebsite
  • Merge requests
  • !500

Improve Language Selection (as part of improved navigation)

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Deano requested to merge webDev4/fdroid-website:langSelect-includesMenu into master Feb 25, 2020
  • Overview 42
  • Commits 4
  • Pipelines 10
  • Changes 23

This has been developed in anticipation of the new F-Droid landing page, but it is nice to be able to provide it earlier.

Further discussion:

Staged here (for example, at the time of writing): https://webdev4.gitlab.io/fdroid-website/en/docs/FAQ_-_Client/

I expect Contributors to tweak the menu to taste, but in my view it is fully functional, adds great functionality and is ready for deployment .

From the commit message:

- On small screens the user can now trigger the language selector via a new menu button at the top of the page, rather than having to scroll down below the content to access it.
- No longer requires javascript.
- Brings the user to the same page they were viewing but in the selected language, rather than sending the user to the landing page and having them try to navigate their way back to the page that they wanted to read.
- The icon for the language selector has a retina display variant (not hugely important to include a low resolution version of the icon except for the fact that some rendering engines add white artifacts to the edges of png images if they are shown much smaller than what the resolution of the image actually is (Firefox).
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: langSelect-includesMenu