General Questions and Dependencies
Hi Nathan,
very cool project. I am looking to add AUG to the mix here via the aug-sfutils
package.
I am wondering if it would be of interest to abstract the base class from mastprov
to be in a separate file, e.g., baseprov.py
which would contain MastProv(ABC)
(renamed to BaseProv
) and the Factory
, that can be consumed by the other APIs outside of pyuda
/imas
/aug-sfutils
.
As for the provenance that could be tracked from AUG, there exists the AUG-journal for each pulse, which aug_sfutils
provides as a dictionary. I envision that the AugProv
class would accept this as meta-data, as well as respective meta-data from the queried signal/image/equilibria/etc.,.
Will add a pull request with an initial pass once I get it working on AFS/TOK.
Additionally, is pyuda
pip installable? All see is this package which I don't think is the correct one.
Nice that you include the try..catch
in the __init__
as opposed to inline.
Best,
Adam Kit