Skip to content

ui#1063 - Added elemhide_not_specific_enough and url_not_specific_enough custom filter alerts

Thomas Greiner requested to merge ThomasGreiner-eyeo/spec:ui_1063 into master

This MR for https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/1063 contains the following changes:

  • Added "elemhide_not_specific_enough" and "url_not_specific_enough" custom filter alerts, based on updated filter alert messages in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/228.
  • Fixed: Removed . character at the end of "snippet_nodomain" filter alert message.
  • Cleanup
    • Renamed "slow performing filters" to "unoptimized filters", because we may want to warn users of filters, even if they're not slow.
    • Moved "slow" custom filter alert to separate table, to clearly differentiate between warnings and errors.
    • Use underscores in alert IDs, as we do in the code (same as in https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/228).
    • Sorted custom filter list alphabetically.

Merge request reports