This project is mirrored from https://chromium.googlesource.com/chromium/src/tools/clang. Updated .
  1. 03 Apr, 2020 3 commits
  2. 02 Apr, 2020 1 commit
  3. 01 Apr, 2020 1 commit
  4. 31 Mar, 2020 2 commits
  5. 29 Mar, 2020 1 commit
  6. 26 Mar, 2020 1 commit
  7. 25 Mar, 2020 2 commits
  8. 24 Mar, 2020 1 commit
    • Nico's avatar
      Roll clang n345635-5d881dd8-1 : n345938-a1762f9c-1. · a560ab4e
      Nico authored
      Ran `./tools/clang/scripts/upload_revision.py a1762f9ceb9549b781b7418c7dbe23fe620648f6`.
      
      Bug: 1064198
      Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
      Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
      Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
      Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
      Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
      Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
      Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
      Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
      Change-Id: Id001edfdd985b7d1f0532107e0a9aa0f87ad084a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113689Reviewed-by: default avatarHans Wennborg <[email protected]>
      Commit-Queue: Hans Wennborg <[email protected]>
      Auto-Submit: Nico Weber <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#752797}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: 77fdd484fd5ee1a8faae2386587d5593c1ba6b6e
      a560ab4e
  9. 20 Mar, 2020 1 commit
  10. 19 Mar, 2020 1 commit
    • Hans Wennborg's avatar
      Roll clang n344329-9284abd0-6 : n345635-5d881dd8-1. · 689fb3d0
      Hans Wennborg authored
      Ran `./tools/clang/scripts/upload_revision.py 5d881dd8a8b8ea6f80bf4ef5b900ca006dacd9bf`.
      
      Bug: 1063010
      Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
      Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
      Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
      Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
      Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
      Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
      Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
      Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
      Change-Id: I3060358001121738e9cc5ae76242b8ba6b18623d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109177
      Auto-Submit: Nico Weber <[email protected]>
      Commit-Queue: Reid Kleckner <[email protected]>
      Reviewed-by: default avatarReid Kleckner <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#751821}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: 2432631b7c55b9042ce2be83da38283e4bc49f47
      689fb3d0
  11. 18 Mar, 2020 1 commit
  12. 15 Mar, 2020 1 commit
  13. 14 Mar, 2020 2 commits
  14. 13 Mar, 2020 2 commits
  15. 12 Mar, 2020 1 commit
  16. 11 Mar, 2020 1 commit
  17. 10 Mar, 2020 1 commit
  18. 09 Mar, 2020 1 commit
  19. 06 Mar, 2020 3 commits
    • Hans Wennborg's avatar
      Revert "IWYU for bind/callback_helpers.h and ptr_util.h" · 25410c20
      Hans Wennborg authored
      This reverts commit b8ffaf4cfcb5e6b6a9916bb1b314820b10b0daf4.
      
      Reason for revert:
      This broke the build of the blink_gc_plugin, which does not use base/
      (see bug). Please don't commit to tools/clang/ without review.
      
      Original change's description:
      > IWYU for bind/callback_helpers.h and ptr_util.h
      > 
      > These missing includes are preventing removal of unused headers from
      > task_runner_util.h and consequently migration from task_runner_util.h to
      > task_runner.h's new PostTaskAndReplyWithResult member method.
      > 
      > The following script was run on every file in the codebase, prioritizing
      > .h over matching .cc to best enforce the rule of not include a header
      > included by your .h :
      > 
      > def Fix(file_path):
      >   content = refactor_lib.ReadFile(file_path)
      > 
      >   # Assume fwd-decls are correct in first pass.
      >   fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
      >   if fwd_decls_match:
      >     print 'fwd_decls_match in %s' % (file_path)
      >     return False
      > 
      >   bind_helpers_match = re.compile(
      >       # Doesn't begin with a comment.
      >       r'\n *[^/\n][^/\n]'
      >       # Anything else after a non-comment start (and don't allow this to capture a comment start either)
      >       r'[^/\n]*'
      >       # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
      >       r'[^<]'
      >       # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
      >       r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
      > 
      >   callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
      > 
      >   ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
      > 
      >   if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
      >     return False
      > 
      >   updated_content = content
      >   if bind_helpers_match:
      >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
      >   if callback_helpers_match:
      >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
      >   if ptr_util_match:
      >     updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
      > 
      >   if updated_content == content:
      >     return False
      > 
      >   # Write updated file
      >   refactor_lib.WriteFile(file_path, updated_content)
      > 
      >   return True
      > 
      > [email protected]
      > (mechanical change for //base API)
      > 
      > Bug: 1026641
      > Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971
      > Reviewed-by: Gabriel Charette <[email protected]>
      > Reviewed-by: danakj <[email protected]>
      > Commit-Queue: Gabriel Charette <[email protected]>
      > Cr-Commit-Position: refs/heads/[email protected]{#747685}
      
      [email protected],[email protected]
      
      Change-Id: I59d6cd69bd898e9f6d10922c67d8c24ba582bf7f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 1026641, 1059359
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2091356Reviewed-by: default avatarHans Wennborg <[email protected]>
      Commit-Queue: Hans Wennborg <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#747804}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: 7a13e2645a7cd50b0bdfd96e72bcdd9b7e9fee26
      25410c20
    • Nico's avatar
      Roll clang n343707-61f538d3-1 : n344329-9284abd0-1. · 7d0befed
      Nico authored
      Ran `./tools/clang/scripts/upload_revision.py 9284abd0040afecfd619dbcf1b244a8b533291c9`.
      
      linux_chromium_chromeos_msan_rel_ng trybot redness: Also red on the
      main waterfall in similar ways and has been for days (!).
      
      ipad-device, iphone-device trybot redness: happens on whitespace cl too, filed crbug.com/1059256
      
      Bug: 1058012
      Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
      Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
      Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
      Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
      Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
      Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
      Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
      Change-Id: Iafc17a96a7d40e9b99f58bce474ed50dc6bfb0da
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086341
      Commit-Queue: Nico Weber <[email protected]>
      Reviewed-by: default avatarHans Wennborg <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#747705}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: 2b76f3eac4172b1fbf1cfce55e6637f9ff3478f0
      7d0befed
    • Gabriel Charette's avatar
      IWYU for bind/callback_helpers.h and ptr_util.h · 95a35c01
      Gabriel Charette authored
      These missing includes are preventing removal of unused headers from
      task_runner_util.h and consequently migration from task_runner_util.h to
      task_runner.h's new PostTaskAndReplyWithResult member method.
      
      The following script was run on every file in the codebase, prioritizing
      .h over matching .cc to best enforce the rule of not include a header
      included by your .h :
      
      def Fix(file_path):
        content = refactor_lib.ReadFile(file_path)
      
        # Assume fwd-decls are correct in first pass.
        fwd_decls_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*class (NullCallback|DoNothing|ScopedClosureRunner);', re.DOTALL).findall(content)
        if fwd_decls_match:
          print 'fwd_decls_match in %s' % (file_path)
          return False
      
        bind_helpers_match = re.compile(
            # Doesn't begin with a comment.
            r'\n *[^/\n][^/\n]'
            # Anything else after a non-comment start (and don't allow this to capture a comment start either)
            r'[^/\n]*'
            # Anything before but an open angle-bracket to avoid cases like unique_ptr<Foo> where you don't need the full definition of Foo.
            r'[^<]'
            # Only match with base:: prefix; more precise, can manually fix missing includes in //base proper in a follow-up pass if needed.
            r'base::(NullCallback|DoNothing|DeletePointer)\b[^*]', re.DOTALL).findall(content)
      
        callback_helpers_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::(IsBaseCallback|EnableIfIsBaseCallback|AdaptCallbackForRepeating|ScopedClosureRunner)\b[^*]', re.DOTALL).findall(content)
      
        ptr_util_match = re.compile(r'\n *[^/\n][^/\n][^/\n]*[^<]base::WrapUnique\b[^*]', re.DOTALL).findall(content)
      
        if not bind_helpers_match and not callback_helpers_match and not ptr_util_match:
          return False
      
        updated_content = content
        if bind_helpers_match:
          updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/bind_helpers.h")
        if callback_helpers_match:
          updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/callback_helpers.h")
        if ptr_util_match:
          updated_content = refactor_lib.AddInclude(file_path, updated_content, "base/memory/ptr_util.h")
      
        if updated_content == content:
          return False
      
        # Write updated file
        refactor_lib.WriteFile(file_path, updated_content)
      
        return True
      
      [email protected]
      (mechanical change for //base API)
      
      Bug: 1026641
      Change-Id: Ic88585c62dd2f74d34c59c708faeddb231aee47f
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2087971Reviewed-by: default avatarGabriel Charette <[email protected]>
      Reviewed-by: default avatardanakj <[email protected]>
      Commit-Queue: Gabriel Charette <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#747685}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: b8ffaf4cfcb5e6b6a9916bb1b314820b10b0daf4
      95a35c01
  20. 05 Mar, 2020 1 commit
  21. 04 Mar, 2020 1 commit
  22. 27 Feb, 2020 1 commit
  23. 26 Feb, 2020 1 commit
    • Hans Wennborg's avatar
      Roll clang n341867-c2900381-1 : n343707-61f538d3-1. · f5a39416
      Hans Wennborg authored
      Ran `tools/clang/scripts/upload_revision.py 61f538d37b80eb589f8990f0b4513d702704ea38`.
      
      Bug: 1051578
      Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
      Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
      Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
      Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
      Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
      Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
      Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
      Change-Id: Ibc750b521a92fe46f5298983d384f0f9670159b4
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2074698Reviewed-by: Nico's avatarNico Weber <[email protected]>
      Commit-Queue: Hans Wennborg <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#744792}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: c30f409c4de8e72e8f338405f686803b13c5bf00
      f5a39416
  24. 18 Feb, 2020 1 commit
  25. 10 Feb, 2020 1 commit
  26. 09 Feb, 2020 1 commit
    • Nico's avatar
      Roll clang n340759-eaabaf7e-2 : n341867-c2900381-1. · 7d1284ae
      Nico authored
      Ran `./tools/clang/scripts/upload_revision.py c29003813ab9bd6ea7b6de40ea8f1fe21979f13f`.
      
      Suppress an msan diag due to new sigaltstack() instrumentation
      that at first glance looks like a false positive.
      
      TBR=hans
      
      Binary-Size: Tracked in https://crbug.com/1047725
      Bug: 1048323,1050279
      Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng
      Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan
      Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel
      Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng
      Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32
      Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64
      Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel
      Cq-Include-Trybots: chrome/try:iphone-device,ipad-device
      Cq-Include-Trybots: chrome/try:linux-chromeos-chrome
      Change-Id: I59ab61e46efe5363fd74988f0ce3e263d16dc69e
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044231Reviewed-by: Nico's avatarNico Weber <[email protected]>
      Commit-Queue: Nico Weber <[email protected]>
      Cr-Original-Commit-Position: refs/heads/[email protected]{#739738}
      Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
      Cr-Mirrored-Commit: d3f3438a5da6d2bc4654908b6e77ae0b81c5d292
      7d1284ae
  27. 05 Feb, 2020 1 commit
  28. 04 Feb, 2020 2 commits
  29. 03 Feb, 2020 1 commit
  30. 31 Jan, 2020 1 commit
  31. 30 Jan, 2020 1 commit