Refactor waiting, good and bad elements
Background
We currently have several strategies on waiting elements displayed before setTimeout
:
- Using "testcase-waitingcontent blocked", like Stylesheet:
<div class="testcase-waitingcontent blocked">Waiting 500ms to trigger script...</div>
<div class="testcase-output-expected">Passed. Stylesheet was blocked.</div>
- Using "testcase-trigger blocked", like Webrtc:
<div id="testcase-status" class="testcase-trigger blocked">Trigger WebRTC connection</div>
<div class="testcase-output-expected">Passed. Connection was blocked.</div>
Note: this leads to expected screenshot errors like this
- Not using "testcase-output-expected", like abort-current-inline-script:
<div class="testcase-waitingcontent blocked">Waiting 500ms to trigger snippet...</div>
Some of the CSS elements used for test status purposes are:
.stripes-red, #testcase-output, .testcase-output-actual, #testcase-output-expected, .trap,
data-expectedresult="blocked", data-expectedresult="notblocked",
.testcase-good-element, .testcase-trigger-passed, .testcase-bad-element, .testcase-trigger-failed
There are also some unused element id's:
<section class="testcase-panel">
<h2 id="usage">Usage</h2>
What to change
- Standardise the elements used with setTimeout (done in !59 (closed))
- Come up with the minimum amount of CSS elements needed.
- Rename elements to reflect its real purpose. I.e.
testcase-output-expected
==>testcase-expected-screenshot
- Rethink the use of
blocked
VSdata-expectedresult
. - Rethink how expected screenshots use
.expected
and.blocked
(among other elements). I.e.:testcase-waitingcontent
should not need.blocked
for its purposes. Also consider #18 (closed) here - Remove unused element id's
Bonus: Filters should remove the visual line break there is after the filter number:
Edited by Toni Feliu