Noissue - Keep protocol keyword in front (!47) · Merge requests · eyeo / adblockplus / abc / adblockpluscore · GitLab

This is an archived project. Repository and other project resources are read-only.

The source project of this merge request has been removed.

Manish Jethani requested to merge skipintro/adblockpluscore:no-move-keyword into next Apr 06, 2019

Issues

None.

Description

In https://issues.adblockplus.org/ticket/7245 we started moving the protocol keyword (e.g. http) to the end of the candidate list. This significantly improved the performance of the matchesAny() function. After this we made more changes, most significantly https://issues.adblockplus.org/ticket/7265, in which we started organizing URL request filters by domain. After all the changes cumulatively, now the change implemented in https://issues.adblockplus.org/ticket/7245 is no longer beneficial and in fact hurts performance slightly. This can be verified using https://gitlab.com/skipintro/benchmark-1 both with and without Acceptable Ads.

In this patch we simply stop moving the protocol keyword from the beginning to the end of the list.

Checklist

Fixes the issue(s)
Passes all tests
Passes linting