The source project of this merge request has been removed.
Issue 7077 - Stop icon animation after notification is clicked
We were calling notificationClosed()
instead of exports.notificationClosed()
, so we were just clearing activeNotification
and not stopping the icon animation.
I also notice that we were calling it from both where we clear the notification, and the close listener. Unnecessary I think, since I figure the former will always trigger the latter. From the chrome.notifications.onClosed docs
The notification closed, either by the system or by user action.
Finally, I got rid of the "If there's an notification, but it isn't a question and it has no links" logic... I couldn't see any point to that, even after searching back through the commit history. I'd be interested to hear what you think to that.
Edited by Dave Vandyke