Custom filters are lost on Edge after clearing cookies and saved website data
Environment
Win10
Microsoft Edge 44.18362.267.0
ABP 0.9.17 (likely a regression introduced with 0.9.14, see comment below)
How to reproduce
- Setup Edge to clear cookies and saved website data when closing the browser (... => Settings => Privacy and Security => Browsing Data => Choose what to clear => check Cookies and saved website data and Always clear this when I close the browser)
- Add a custom filter.
- Wait 60s so a backup can take place.
- Restart the browser.
- Go to the options page.
Observed behavior
The filter is missing.
Expected behavior
The filter should be displayed.
Notes
- When we changed the
Subscription.serialize()
andSubscription.serializeFilters()
methods to return a generator, we missed to adapt the code here. This change was released with 0.9.14 (respectively 3.5).
/cc @kzar @snoack @rossg-eyeo
Edited by Dave Vandyke