Log ElementHidingException filters in the devtools panel
Ross pointed out that element hiding whitelisting filters are not listed in the Adblock Plus developer tools panel. Looking into it this is expected, but it would be nice if they were.
What to change
Once #6428 lands, modify the
generateStyleSheetForDomain() call in
lib/contentFiltering.json adblockpluschrome to request the active exception filters as well if tracing is enabled, as such
include.preload.js should now send active exception filters with messages to
hitLogger.traceElemHide. Since ElemHideException filters are not actually whitelisting filters,
devtools.js will now need to also check for elemhide exceptions when setting the whitelisted property before adding a new record to the panel. Note: We will aim for including this and it's blocking ticket with the next major release for UI.
Tips for testers
- Add the following custom filters:
- Open a new tab, open the developer tools for the tab and switch to the Adblock Plus developer tools pane.
- Browse to https://news.ycombinator.com in the tab.
Ensure that the exception filters are represented as expected and can be added and removed via the devtool options, as well as the custom filters field in the abp options page.
This is a transition ticket from trac issue #6427 which got a bit out of whack anyway due to my misunderstanding of this implementation. Turns out, the spec is the only thing which actually needs to be changed and is not a blocker.