Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • A adblockpluschrome
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • eyeoeyeo
  • adblockplus
  • adblockpluschrome
  • Issues
  • #90
Closed
Open
Issue created Oct 01, 2019 by Ross Green@rossg-eyeo

Subdocument frames are not collapsed in Firefox

Environment

ABP 3.6.3.2396
Firefox 51.0 / Windows 10 1809
Firefox 69.0.1 / Windows 10 1809

How to reproduce

  1. Navigate to the subdocument test page.
  2. Add the filter.
  3. Refresh the page.

Observed behavior

The subdocument is blocked but the frame is not collapsed.

Expected behavior

Frame to collapse as it does in Chrome / other browsers.

Hints for testers

In order to address this issue we had to refactor the whole element collapsing mechanism, and adapt the filter composer code (i.e. the "Block element" dialog) as well. Please make sure to thoroughly retest these features.

See also

The previous ticket (#6917) on Trac.
The related Firefox ticket (https://bugzilla.mozilla.org/show_bug.cgi?id=1488226) on Bugzilla.

Edited Sep 17, 2020 by Sebastian Noack
Assignee
Assign to
Time tracking