Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • A adblockpluschrome
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • eyeoeyeo
  • adblockplus
  • adblockpluschrome
  • Issues
  • #244
Closed
Open
Issue created Aug 18, 2020 by Thomas Greiner@ThomasGreinerMaintainer

Expose information to ignore notifications in case of data corruption

Background

In case of a data corruption, the extension may not be able to remember whether a notification has been shown already. Therefore we should ignore notifications in case we are aware of a data corruption.

See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/-/issues/829.

What to change

Instruct adblockpluscore to ignore notifications (set notifications.ignored = true whenever we detect data corruption.

Hints for testers

In the extension, you can call setDataCorrupted(true) in lib/subscriptionInit.js in order to tell the extension that there is a data corruption. Any code that's running after that, will assume that a data corruption is present and should behave accordingly (e.g. data corruption notification should be shown).

Edited Sep 18, 2020 by Thomas Greiner
Assignee
Assign to
Time tracking