Skip to content

Issue 7273 - Resolve filter parsing error messages in UI

Thomas Greinerrequested to merge
ThomasGreiner-eyeo/abp/ui/adblockplus:issue_7273 into release-2019-1

This MR for #320 (closed) contains the following changes:

  • Created convertError() function in message responder
    • Got rid of redundant type property when passing on errors to UI
  • Created getErrorMessage() function in common.js (at least until we start creating a composer.js bundle)
    • Pass error selector unconditionally
  • Updated messaging docs
  • Fixed: Updated "line" translatable string to allow translators to be more flexible with arranging of the line prefix (I'll double-check that with C&T)

It doesn't include the following changes:

  • Support HTML in filter parsing error messages
  • Fix: \n separator in IOFilterTable doesn't cause line breaks

Merge request reports