Retry failed filter list updates
Background / User story
As ABP user I would like to have the most updated filter list so ABP performs as it should. Filter list downloads sometimes fail in which case it is not retried until the next regular download attempt is made. Therefore retrying failed downloads would be one way to get users the most updated filter lists quicker than in the current version.
What to change
- Design: N/A
- Research: N/A
- Spec:
-
Development:
- The first time a filter list download fails (incl. HTTP errors, JavaScript errors, other network errors) after a successful, regular download:
- Retry after 4% of regular filter list update interval (i.e. 4% in total since initial download attempt).
- Retry after 7% of regular filter list update interval (i.e. 12% in total since initial download attmept).
- Retry after 13% of regular filter list update interval (i.e. 25% in total since initial download attempt).
- Retry after 25% of regular filter list update interval (i.e. 50% in total since initial download attempt).
- Stop retrying and wait for the next regular download (i.e. 100% in total since initial download attempt).
- If users are offline during the next scheduled retry attempt, we mustn't attempt it right after they're online again but should instead define a time range within which the retry should occur (see existing code in downloader).
- For retry attempts:
- Make sure to not increment the downloadable's download count.
- Include
errorCount
in addition todownloadCount
parameter.
-
Log errors in console (incl. stack traces; HTTP response headers and body).(moved to #715 (closed))
- The first time a filter list download fails (incl. HTTP errors, JavaScript errors, other network errors) after a successful, regular download:
Hints for testers
TBD
Hints for translators
TBD
Integration notes
Requires https://gitlab.com/eyeo/adblockplus/adblockpluscore/-/issues/211.
Edited by Thomas Greiner