Error message triggered on every reload
Description
We've added an error that should trigger when a filter list fails to download in #7 (closed). Currently this error is triggered not only when a filter list fails to download, but every time the Options page is opened, if there exist a filter list that failed downloading at some point. (see https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/7#note_187503412)
Environment
release 2019-1
- not browser specific
Reproduction steps
- get the latest 2019-1 build
- navigate to the Options page and add a Language
- simulate filter list download failure (I do this by blocking the request in the extension's background page, but there might be other ways)
- Observe: the error message gets triggered (red banner at the top of the Options page)
- reload the page
- Observe: the error message gets triggered again
Expected
Error should be only triggered when the extension actually makes a request to download a filter list and it fails, not on every reload of the Options page.
Edited by Ursa Kacar