Message responder still requires filter validation module
Steps to reproduce
- Remove adblockpluschrome/lib/filterValidation.js and adblockpluschrome/qunit/tests/filterValidation.js.
- Build the extension.
Oberved behavior
Build fails because it cannot find "filterValidation" module.
Expected behavior
Build succeeds.
Integration notes
Remove adblockpluschrome/lib/filterValidation.js and adblockpluschrome/qunit/tests/filterValidation.js.
Hints for testers
Filter validation error messages in the desktop settings page should continue to work:
- …when loading the page with an invalid filter in the custom filter table.
- …when adding an invalid filter.
- …when replacing a valid with an invalid filters.
- …when pasting multiple filters which include one or more invalid filters.
Anytime an invalid filter is added via the table header, the error should be shown in the table footer. When an invalid filter replaces an existing filter, the error should be shown in the tooltip of the icon in the alert column.
The error message should be preceded with the line number corresponding to the invalid filter, when attempting to add multiple filters at once.
Edited by Thomas Greiner